Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix master - TypeTrait semantic fails for non static aggregate members #8992

Merged
merged 1 commit into from Nov 26, 2018
Merged

fix master - TypeTrait semantic fails for non static aggregate members #8992

merged 1 commit into from Nov 26, 2018

Conversation

ghost
Copy link

@ghost ghost commented Nov 22, 2018

Edit: this is no WIP anymore

@dlang-bot dlang-bot added the WIP Work In Progress - not ready for review or pulling label Nov 22, 2018
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#8992"

@RazvanN7
Copy link
Contributor

At some point, please push a commit containing Fix Issue 19420 so that the bot links the PR with the bugzilla issue. Thanks!

@ghost
Copy link
Author

ghost commented Nov 22, 2018

Yes i know @RazvanN7 but for now the bug is not "shipped" so the issue number doesn't need to appear in the changelog, that's why i didn't follow the usual procedure.

@ghost ghost changed the title [WIP] fix master - TypeTrait semantic fails for non static aggregate members fix master - TypeTrait semantic fails for non static aggregate members Nov 23, 2018
@ghost
Copy link
Author

ghost commented Nov 23, 2018

Ready for review, please someone remove the WIP label, thx.

@RazvanN7 RazvanN7 removed the WIP Work In Progress - not ready for review or pulling label Nov 23, 2018
src/dmd/typesem.d Outdated Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 25, 2018

All phobos instances of alias ... = AliasSeq!(__traits( can be simplified now and test pass. Good sign that the bug is fixed.

@ghost
Copy link
Author

ghost commented Nov 25, 2018

I've found (and fixd) another kind of expressions that needed special processing in my IZ library. (when a ScopeExp is returned by __traits). I cannot try to convert the wholeness of the aliases that can be found in the DUB packages so it will be necessary to ask people to try the new way of aliasing during the beta that will introduce the feature, it's not totally impossible that some special cases still miss and for them the semantic is different of what gave AliasSeq in this that what's aliased is the expression type, because of the final if else falling back to getType.

src/dmd/traits.d Show resolved Hide resolved
@ghost
Copy link
Author

ghost commented Nov 26, 2018

ping @thewilsonator, green tests.

@dlang-bot dlang-bot merged commit cc65614 into dlang:master Nov 26, 2018
@ghost ghost deleted the fixup_alias_ass_traits-round2 branch November 26, 2018 14:34
@ghost
Copy link
Author

ghost commented Nov 26, 2018

thx.

@RazvanN7
Copy link
Contributor

@thewilsonator Please do not merge PRs with such haste. I was in the process of reviewing this.

Let aside the review, the PR does not contain the issue number so the bot did not link the bugzilla issue: https://issues.dlang.org/show_bug.cgi?id=19420

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants