New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix master - TypeTrait semantic fails for non static aggregate members #8992
Conversation
Thanks for your pull request and interest in making D better, @bbasile! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + dmd#8992" |
At some point, please push a commit containing Fix Issue 19420 so that the bot links the PR with the bugzilla issue. Thanks! |
Yes i know @RazvanN7 but for now the bug is not "shipped" so the issue number doesn't need to appear in the changelog, that's why i didn't follow the usual procedure. |
Ready for review, please someone remove the WIP label, thx. |
All phobos instances of |
I've found (and fixd) another kind of expressions that needed special processing in my IZ library. (when a ScopeExp is returned by |
ping @thewilsonator, green tests. |
thx. |
@thewilsonator Please do not merge PRs with such haste. I was in the process of reviewing this. Let aside the review, the PR does not contain the issue number so the bot did not link the bugzilla issue: https://issues.dlang.org/show_bug.cgi?id=19420 |
Edit: this is no WIP anymore