Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[trivial] fix issue 19730 - if (auto x) {} isn't properly rejected #9447

Merged
merged 2 commits into from Mar 12, 2019
Merged

[trivial] fix issue 19730 - if (auto x) {} isn't properly rejected #9447

merged 2 commits into from Mar 12, 2019

Conversation

ghost
Copy link

@ghost ghost commented Mar 12, 2019

To match the rule

 TypeCtors Identifier = Expression

even if accepting the invalid code didn't hurt.

@dlang-bot dlang-bot added the Trivial typos, formatting, comments label Mar 12, 2019
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @Basile-z! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19730 regression if (auto x) {} isn't properly rejected

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "stable + dmd#9447"

Copy link
Contributor

@thewilsonator thewilsonator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise Looks good

@Geod24
Copy link
Member

Geod24 commented Mar 12, 2019

Please add tests for if (const size_t value) as well.
Buildkite seems to indicate this would break with this PR

@ghost
Copy link
Author

ghost commented Mar 12, 2019

Yeah this "trivial" PR is a failure right now and it's very surprising not to see the form of IfCondition that it breaks in the whole official test suite.

@thewilsonator thewilsonator merged commit 5c3d570 into dlang:stable Mar 12, 2019
@ghost ghost deleted the issue-19730 branch March 13, 2019 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Fix Trivial typos, formatting, comments
Projects
None yet
4 participants