Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19731: throw away semantic3 run after return type inference to avoid missing invariants #9448

Conversation

FeepingCreature
Copy link
Contributor

@FeepingCreature FeepingCreature commented Mar 12, 2019

This avoids a case where forcing semantic3 via querying the return type of a struct member function led it to ignore invariants, because they were not yet determined at that point, and later on semantic3 had already run.

I don't like this solution, but I don't know enough DMD to come up with something better. At least it should be a cornercase - auto functions aren't that common, hopefully.

edit: The point of this PR is mostly to run the CI pipeline to flush out possible (likely) breakage, and to softly poll for a better approach.

edit: OH GOD IT BROKE EVERYTHING

@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
19731 normal auto struct methods whose address is taken don't test invariants

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9448"

@FeepingCreature
Copy link
Contributor Author

Gonna close it for now. This doesn't work.

@FeepingCreature FeepingCreature deleted the fix/Issue-19731-throw-away-return-inference-semantic3 branch May 5, 2019 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
2 participants