Fix Issue 19731: throw away semantic3 run after return type inference to avoid missing invariants #9448
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoids a case where forcing semantic3 via querying the return type of a struct member function led it to ignore invariants, because they were not yet determined at that point, and later on semantic3 had already run.
I don't like this solution, but I don't know enough DMD to come up with something better. At least it should be a cornercase - auto functions aren't that common, hopefully.
edit: The point of this PR is mostly to run the CI pipeline to flush out possible (likely) breakage, and to softly poll for a better approach.
edit: OH GOD IT BROKE EVERYTHING