fix Issue 19734 - isDataseg returns true for non-static declarations

[ibuclaw]

This is the quick fix to avoid ICE. The real fix should be handled by issue 19735.

[dlang-bot]

Thanks for your pull request, @ibuclaw!

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19734	blocker	isDataseg returns true for non-static declarations
✓	19735	critical	Error: variable extern symbols cannot have initializers

⚠️⚠️⚠️ Warnings ⚠️⚠️⚠️

• Regression or critical bug fixes should always target the stable branch. Learn more about rebasing to stable or the D release process.

To target stable perform these two steps:

1. Rebase your branch to upstream/stable:

git rebase --onto upstream/stable upstream/master

2. Change the base branch of your PR to stable

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9451"

[ibuclaw]

Wonderful, the compiler generated static __critsec variable is marked as STCtemp.

[WalterBright]

Looking at the bug report, the problem isn't in isDataseg(), it's that extern is propagating into the function scope.

[ibuclaw]

Dug a little further to find the place where it erroneously propagates.

[PetarKirov]

The CIs look promising. I've deprecated a Linux test run on the autotester as it was due to an OOM.