fix Issue 19857 - Name mangling mismatch when compiling with -dip1000 #9789
Conversation
|
Thanks for your pull request, @WalterBright! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "stable + dmd#9789" |
WalterBright
force-pushed
the
inferRetMangle
branch
from
63201b7
to
9d3b0a7
Compare
test/compilable/scopeinfer.d
Outdated
| //pragma(msg, S.top.mangleof); | ||
|
|
||
| version (Win32) | ||
| static assert(S.top.mangleof == "_D4test__T5StackZQh3topMFNaNbNcNiNfZPi"); |
There was a problem hiding this comment.
What about other platforms?
There was a problem hiding this comment.
The complete mangling varies slightly from platform to platform, but the issue under test does not, so one platform will suffice.
There was a problem hiding this comment.
@wilzbach That line needs to s/4test/10scopeinfer/
|
dlang-bot says this should target the stable branch. Otherwise, LGTM. |
All bug fixes should target stable. |
|
But it's still blocking a lot of people using -dip1000 and we want to push it out as early as possible, hence I rebased to stable for you. |
WalterBright
force-pushed
the
inferRetMangle
branch
from
2bb0ff8
to
118da36
Compare
WalterBright
requested review from
andralex,
Geod24,
ibuclaw,
MartinNowak,
rainers and
RazvanN7
as code owners
|
Oh, not again with the borked up git history. |
|
Sebastian already changed to stable. |
|
@WalterBright Sebastian fixed the commits for you. Don't push anything else. |
Yup and I also rebased your commits. You reverted that my force-pushing over it. I restored it for you again. (and changing the target branch to stable) |
| fail_compilation/retscope.d(249): Error: cannot implicitly convert expression `__lambda1` of type `void* delegate() pure nothrow @nogc @safe` to `void* delegate() @safe` | ||
| fail_compilation/retscope.d(249): Error: cannot implicitly convert expression `__lambda1` of type `void* delegate() pure nothrow @nogc @safe` to `void* delegate() @safe` | ||
| fail_compilation/retscope.d(250): Error: cannot implicitly convert expression `__lambda2` of type `void* delegate() pure nothrow @nogc @safe` to `void* delegate() @safe` | ||
| fail_compilation/retscope.d(250): Error: cannot implicitly convert expression `__lambda2` of type `void* delegate() pure nothrow @nogc @safe` to `void* delegate() @safe` |
There was a problem hiding this comment.
That does not look good though. I'm all for the mangling change, but it shouldn't break the error message.
There was a problem hiding this comment.
The error message was changed because DMD used different mangling (and thus function names) with -preview=dip1000
No description provided.