Fix issue 19891 - Confusing error messages for auto ref parameters with default values

[SSoulaimane]

19891.

Should this go stable?

[thewilsonator]

I think so.

[WalterBright]

Should this go stable?

No. It's a minor issue, and not a regression.

[jacob-carlborg]

No. It's a minor issue, and not a regression.

All bug fixes should target stable unless they are big/complex/introduce breaking changes.

[WalterBright]

I don't really get what this means.

[SSoulaimane]

Wait until I mark this PR ready for review, I found an issue which may result in removing that flag.

[SSoulaimane]

What do you suggest would be more descriptive.

[WalterBright]

All bug fixes should target stable unless they are big/complex/introduce breaking changes.

When "All" is used, one should be careful not to drive over a cliff. In this case, it's a trivial refinement, and not worth the risk of destabilizing the stable version.

[jacob-carlborg]

It's not my rules.

[dlang-bot]

Thanks for your pull request and interest in making D better, @SSoulaimane! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

• My PR is fully covered with tests (you can see the annotated coverage diff directly on GitHub with CodeCov's browser extension
• My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
• I have provided a detailed rationale explaining my changes
• New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

---

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close	Bugzilla	Severity	Description
✓	19891	minor	Confusing error message for auto ref parameters with default values

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + dmd#9894"