This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix test coverage merging with the test_runner #1629
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a weird case with
std.stdio
wheredoTest
is called 4x and for the first three times currently without the merge flag been set.This is a simple fix that just moves the setting of the merge flag in the static constructor, however if someone wants to look deeper into this, here's a strip down version of the
test_runner
.For
std.json
or any other module it will print as expectedwhere
merge
is an additional log output in the static deconstructor ofcover.d
which just logs the currentmerge
flag. Now withstd.stdio
for some reasondoTest
is called 4xFor reference:
dlang/phobos#4719