New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch to CircleCi #4719
Switch to CircleCi #4719
Conversation
2b85d9f
to
37bc3c9
Compare
Single module tests are there for development, not that important to run them. |
@MartinNowak leaving this to you |
@andralex we already agreed on this move, but @MartinNowak lacks the permission to enable CircleCi. |
a2c1b89
to
04377b1
Compare
Current coverage is 88.75% (diff: 100%)@@ master #4719 diff @@
==========================================
Files 121 121
Lines 74070 74070
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 65737 65740 +3
+ Misses 8333 8330 -3
Partials 0 0
|
d9bac2c
to
5ec8255
Compare
So I inserted some log output in So for example running
and indeed if I run it again the coverage gets merge and thus doubled:
and if i run another module it is pertained:
However once
Has anyone an idea what's happening here? |
Maybe a bug in the merge code? Could be sth. like those other modules are initialized with an empty coverage array which then deletes the existing information. |
BTW, gitlab has the nice |
setup_repos() | ||
{ | ||
# set a default in case we run into rate limit restrictions | ||
local base_branch="master" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tabs
I think I found the problem. In test runner |
5ec8255
to
a7d782c
Compare
a7d782c
to
2e536e0
Compare
Looks good now? |
Thanks @MartinNowak for the quick-deployment of the fix :)
That's weird (I expected to get more hits because with the test_runner we should see coverage of code executed across modules, but we shouldn't get 1.2K new, missed lines). |
2e536e0
to
23f66af
Compare
Hmm there still seem to be some issues. 1) Current output with
|
Judging by this recent discussion it's probably nice to run them too, s.t. such random discoveries don't happen again. |
@MartinNowak what steps do we need to take to grant you appropriate rights? |
Thanks to the help of @WalterBright and @CyberShadow we have already enabled CircleCi (see the checks box here), but this PR is pending because we have some weird issues with coverage reporting from |
23f66af
to
2a2b3a2
Compare
Rebased to run in the "old mode" (individual module test), s.t. other PRs aren't displayed as broken and we have more time & peace to dig into this issue. (Looking at this NG discussion we might want to keep the individual module testing anyways). |
{ | ||
# set a default in case we run into rate limit restrictions | ||
local base_branch="master" | ||
if [ -n ${CIRCLE_PR_NUMBER:-} ]; then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Needs the same fix as dmd#6066. :)
2a2b3a2
to
ba5f55a
Compare
Done. Thx. Are you already submitting one for druntime? |
Auto-merge toggled on |
Merging this, as CircleCI is currently just red. |
Nope. Please do. |
Follow-up to dlang/druntime#1625 and dlang/dmd#6022.
Short summary
style
target (hopefully more friendly to developers) - it bootstraps dscanner too (CC @Hackerpilot)test_runner
to generate the coverage data, this means that (a) coverage across modules will be detected, but (b) that we don't have a CI anymore that check whether all individual modules build (e.g. Fix cycles in Phobos #4493 or issue 16291) CC @schveiguy.CC @MartinNowak