-
-
Notifications
You must be signed in to change notification settings - Fork 424
Add support for RISCV{32,64} to glibc bindings #2355
Conversation
Thanks for your pull request, @ibuclaw! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2355" |
Fixed up src/core/sys/posix/sys/msg.d, as there is a difference between |
Please rebase. |
Rebased. |
Thanks. |
c_long[12] __regs; | ||
c_long __sp; | ||
static if (__traits(getTargetInfo, "floatAbi") == "double") | ||
double[12] __fpregs; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@TurkeyMan - First user of __traits(getTargetInfo)
! (ABI models of RISC-V are "soft", "single", "double", and "quad" https://github.com/riscv/riscv-c-api-doc/blob/master/riscv-c-api.md#preprocessor-definitions :-)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! We should support basically everything we can behind getTargetInfo
! It's a nice clean tidy and centralised way to get at target info!
Backported from upstream druntime master. Reviewed-on: dlang/druntime#2355 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@266713 138bc75d-0d04-0410-961f-82ee72b054a4
Backported from upstream druntime master. Reviewed-on: dlang/druntime#2355 From-SVN: r266713
Tested on riscv-qemu.