This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix Issue 19524 - Make core.checkedint work in betterC #2426
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do this by making everything in checkedint a zero-argument template function. The risk is that this changes the function mangling and may cause `mulu` etc. to cease being intrinsic functions if a compiler had been handling them specially, although DMD does not appear to have been doing this.
|
Thanks for your pull request, @n8sh! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2426" |
And you didn't bother checking other compilers? Are they not important enough to give due notice? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Do this by making everything in checkedint a zero-argument template function. The risk is that this changes the function mangling and may cause
muluetc. to cease being intrinsic functions if a compiler had been handling them specially, although DMD does not appear to have been doing this.