Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 19526 - make RefCounted work in betterC #6820

Merged
merged 1 commit into from Dec 30, 2018

Conversation

n8sh
Copy link
Member

@n8sh n8sh commented Dec 30, 2018

Array needs dlang/druntime#2426 to work in betterC.

@dlang-bot
Copy link
Contributor

dlang-bot commented Dec 30, 2018

Thanks for your pull request, @n8sh!

Bugzilla references

Auto-close Bugzilla Severity Description
19526 enhancement make std.typecons.RefCounted work in betterC

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#6820"

@n8sh
Copy link
Member Author

n8sh commented Dec 30, 2018

Have to remove @betterC from some of the tests because unlike normal unittests they are in a different module can't refer to private members.

@n8sh n8sh force-pushed the issue-19526-19527 branch 2 times, most recently from f38091c to cb8c89c Compare December 30, 2018 19:15
@n8sh n8sh changed the title Fix Issue 19526 & 19527 - make RefCounted & std.container.array.Array work in betterC Fix Issue 19526 - make RefCounted work in betterC Dec 30, 2018
@n8sh n8sh removed the Blocked label Dec 30, 2018
@n8sh
Copy link
Member Author

n8sh commented Dec 30, 2018

Removed changes for std.container.array.Array because it needs TypeInfo.

Copy link
Member

@wilzbach wilzbach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dlang-bot dlang-bot merged commit c47be25 into dlang:master Dec 30, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants