This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
Fix issue 17563 - Expose gc_inFinalizer #2873
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @PetarKirov! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + druntime#2873" |
PetarKirov
force-pushed
the
fix-issue-17563-add-gc-in-finalizer
branch
2 times, most recently
from
b15ff11
to
7aef8b8
Compare
schveiguy
suggested changes
Dec 17, 2019
rainers
reviewed
Dec 17, 2019
rainers
reviewed
Dec 17, 2019
PetarKirov
force-pushed
the
fix-issue-17563-add-gc-in-finalizer
branch
2 times, most recently
from
da1a9b1
to
ec3845a
Compare
PetarKirov
requested review from
DmitryOlshansky and
MartinNowak
as code owners
|
@rainers @schveiguy Thanks for the review! I think I addressed all of your comments: |
PetarKirov
commented
Dec 17, 2019
PetarKirov
force-pushed
the
fix-issue-17563-add-gc-in-finalizer
branch
from
ec3845a
to
95f7df9
Compare
|
@CyberShadow is there any way to restart DAutoTest without restarting all of the other CIs? Like a restart button that only people in the GitHub org can click? |
|
Unfortunately such a feature does not exist at the moment. |
…function Motivation: we want the @safe-ty of the proxy functions to based on the @safe-ty of the underlying functions of the GC interface. This is not currently possible as all access to this interface goes through a `__gshared GC instance` variable. Trusted functions are usually a bad idea, but this one is private, in a module not meant to be imported by user code, so the author believes that it's a better solution than sprinkling @trusted lambdas all over the module.
See the changelog entry and source code comments for details.
PetarKirov
force-pushed
the
fix-issue-17563-add-gc-in-finalizer
branch
from
95f7df9
to
63d86ee
Compare
schveiguy
approved these changes
Dec 19, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the changelog entry and source code comments for details.