This repository has been archived by the owner on Oct 12, 2022. It is now read-only.
merge stable #3434
Merged
merge stable #3434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MartinNowak
commented
Apr 13, 2021
MartinNowak
commented
- fix issue 21712 - [REG 2.096.0] sometimes coverage *.lst files are corrupted
- core.lifetime: Tag -betterC compatible unittests
- Fix Issue 21701 - casWeak is not implemented
- Fix Issue 21371 - core.stdcpp.allocator: _Adjust_manually_vector_aligned checks for sentinel unconditionally (Windows only)
- Fix Issue 21784: Allow detached threads to be joined
- Allow detached threads to be joined on Windows too
…rrupted dont use the same buffer to read+split the LST and read+split the D
To avoid future regressions w.r.t. to -betterC
…ned checks for sentinel unconditionally (Windows only) This bug resulted in assertion failures when deleting large blocks of memory using core.stdcpp.allocator on Windows. _Allocate_manually_vector_aligned only sets a sentinel when version(_DEBUG) so _Adjust_manually_vector_aligned should only check for this sentinel when version(_DEBUG). Additionally change the linkage of those functions from C++ to D to avoid possible linker confusion. Also changed the logic by which allocator.d infers _DEBUG to resemble the the logic for _ITERATOR_DEBUG_LEVEL in utility.d.
This is useful when a thread terminates before the caller is able to join().
PR dlang#3418 allowed them on Posix; extend it to Windows too. The added test/thread/src/join_detach.d test now passes on Windows (tested by LDC).
MartinNowak
requested review from
andralex,
ibuclaw,
schveiguy,
TurkeyMan,
WalterBright and
wilzbach
as code owners
|
Thanks for your pull request, @MartinNowak! Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3434" |
Geod24
approved these changes
Apr 13, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.