-
-
Notifications
You must be signed in to change notification settings - Fork 425
fix some compatibility issues for Solaris systems #3624
fix some compatibility issues for Solaris systems #3624
Conversation
Thanks for your pull request and interest in making D better, @BarrOff! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + druntime#3624" |
cc @ibuclaw |
src/core/stdcpp/string_view.d
Outdated
const(T)* _M_str; | ||
|
||
alias __data = _M_str; | ||
alias __size = _M_len; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Developer Studio doesn't implement this, so maybe add a pragma saying as much. Falling back on doing what gcc does is the safe option, which seems to be what you're doing here.
@ibuclaw is this good to go? |
SIG stuff are already defined elsewhere (with the wrong value), and missing SHF_COMPRESSED. |
What can/should I still do about the SIG stuff? I already moved Concerning |
SIGVTALRM and SIGXFSZ are already defined here: druntime/src/core/sys/posix/signal.d Lines 2836 to 2838 in a17bb23
They just have the wrong value.
On Solaris 11.4, it's defined as |
I fixed the two values and added If that is ok now, the only remaining problem is the part about However, Developer Studio has been replaced by gcc in OpenIndiana, in OmniOS also and I suppose in SmartOS too. The only system still using Developer Studio is the official Oracle Solaris. To solve this problem I see two possible solutions:
|
Maybe someone should send a patch in. :-)
I think it's reasonable to default to CppRuntime_Gcc on Solaris, and use Sun only if requested by the -target triplet. |
src/core/sys/posix/signal.d
Outdated
enum SIGVTALRM = 28; | ||
enum SIGXFSZ = 31; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You can remove these now. :-)
I have removed the redundant signals and reverted the change to string_view.d . Besides, I opened a pull request on DMD to default to |
enum SI_ASYNCIO = -4; | ||
enum SI_MESGQ = -5; | ||
|
||
enum SIGIO = SIGPOLL; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd move this with the others, but don't think it would be harming anything at this point in time.
Hello,
some fixes to aid compilation on Solaris/Illumos based systems.
I successfully tested the changes on a recent Solaris/Illumos installation.