Improve the netlify preview to show packages #308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your pull request, @wilzbach! |
wilzbach
commented
Mar 29, 2018
| . "$(curl -fsSL --retry 5 --retry-max-time 120 --connect-timeout 5 --speed-time 30 --speed-limit 1024 https://dlang.org/install.sh | bash -s install "dmd-${DMD_VERSION}" --activate)" | ||
| . "$(curl "${CURL_FLAGS[@]}" https://dlang.org/install.sh | bash -s install "dmd-${DMD_VERSION}" --activate)" | ||
|
|
||
| curl "${CURL_FLAGS[@]}" https://code.dlang.org/api/packages/dump | gunzip > mirror.json |
There was a problem hiding this comment.
We could also upload a JSON dump somewhere else if this becomes a problem, but for now there aren't too many PRs at dub-registry so having a separate file for this will probably just be more work.
WebFreak001
reviewed
Mar 29, 2018
source/dubregistry/mirror.d
Outdated
| packs = requestHTTP(url ~ InetPath("api/packages/dump")).readJson().deserializeJson!(DbPackage[]); | ||
| } | ||
|
|
||
| logInfo("Updated for %s downloaded.", url); |
There was a problem hiding this comment.
shouldn't this say updates?
source/dubregistry/mirror.d
Outdated
| @@ -71,6 +92,8 @@ nothrow { | |||
| logDiagnostic("Full error: %s", e.toString().sanitize); | |||
| } | |||
| } | |||
|
|
|||
| logInfo("Updated for '%s' successfully processed.", fileOrUrl); | |||
wilzbach
force-pushed
the
netlify-mirror
branch
from
73d0c37
to
2c6cf39
Compare
WebFreak001
approved these changes
Mar 29, 2018
wilzbach
force-pushed
the
netlify-mirror
branch
from
2c6cf39
to
efcc586
Compare
|
FYI @ others: I'm going to merge this now, s.t. we can play with the preview on the other PRs. As there's no auto-deploy or similar setup, this shouldn't be an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #307, downloading the Json doesn't work (or well it takes 10 minutes), so I made
--mirrorsupport importing a manually downloaded copy of the Json file.This is also handy for my local development, when I want to quickly nuke the entire database and on my machine
--mirror=...doesn't work well either (could be due to my crappy internet though).