Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Actually copy copyFiles when building in Visual Studio. #2105

Merged
merged 2 commits into from Feb 14, 2021

Conversation

veelo
Copy link
Contributor

@veelo veelo commented Feb 9, 2021

From the changelog:

copyFiles can now be used in VisualD projects.

Files that are needed for the application to run can be specified in the copyFiles build option, which causes these files to be copied to the target path. The dub generator for VisualD now replicates this behaviour, so that this kind of applications can be successfully debugged in Visual Studio.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @veelo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Co-authored-by: Mathias LANG <geod24@gmail.com>
@maxhaton
Copy link
Member

@veelo ready for merge?

@veelo
Copy link
Contributor Author

veelo commented Feb 14, 2021

Yes this is ready, thank you.

@dlang-bot dlang-bot merged commit ff15480 into dlang:master Feb 14, 2021
@maxhaton
Copy link
Member

Yes this is ready, thank you.

Good to go

@veelo veelo deleted the copy_files branch February 14, 2021 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants