Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add environment variables to BuildSettings #2121

Merged
merged 5 commits into from May 19, 2021
Merged

Conversation

shoo
Copy link
Contributor

@shoo shoo commented Mar 27, 2021

This change is to specify environment variables when running various commands for preparation and cleanup, building, testing, and so on.
Environment variables can be specified both in project-specific settings and in dub settings.

This change will fix the following two issues:

And related:

@andre2007 It seems to be related to some of the issues you suggested. I would appreciate your opinion.

@dlang-bot
Copy link
Collaborator

Thanks for your pull request and interest in making D better, @shoo! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

@andre2007
Copy link
Contributor

@shoo Thanks a lot for working on this. The PR looks really solid and complete. I can't see any obvious issues or missing things.

@shoo
Copy link
Contributor Author

shoo commented May 19, 2021

Is there anyone who can review this PR?
Or can you recommend a suitable reviewer?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants