Also add options when we combine buildsettings

[ryuukk]

Fixes #2193

[PetarKirov]

Hi @ryuukk, thanks for the thorough investigation and the fix! Can you add a test that reproduces the issue you described and asserts that different import paths can be properly retrieved?

[ryuukk]

I didn't notice this was still open my bad!

I am not sure how to write tests for that kind of stuff..

I'll give another try whenever i got some free time

[ryuukk]

I don't think this even need a test, someone just forgot to copy every field

[rikkimax]

Agreed, rebase and LGTM!

[ryuukk]

I don't like git, i don't know what's missing or what i should do next

If someone can pick up this PR and do the changes required that would be nice

[ryuukk]

7 months for a 1 line fix, can we do something about this one please?

[WebFreak001]

sorry this PR was getting lost. Could you rebase or allow contributors from dlang/dub to push to your branch? Then the tests should pass again.

If you don't want to rebase this yourself, I rebased locally, but I can't push to your branch, at the right there is a checkbox to allow others to push to your branch, so click that and tell us if you want me to do it for you.

If you want to rebase yourself you can do so like this:

# in your checked out repostiory
# first associate the remote "upstream" with dlang/dub
git remote add upstream https://github.com/dlang/dub.git
# get commits from there
git fetch upstream
# checkout your own master
git checkout master
# update with upstream master commits (should just fast-forward)
git pull upstream master
# checkout your feature branch
git checkout patch-1
# rebase (reapplies the patch commits here onto master)
git rebase master
# force push to patch-1 (as we rewrote history, we need to force, so the old actual commit is deleted from history)
git push origin patch-1 -f

[ryuukk]

@WebFreak001 thanks a lot!