Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix CI issue2051 failing. #2208

Merged
merged 1 commit into from Feb 6, 2022
Merged

Conversation

rikkimax
Copy link
Contributor

@rikkimax rikkimax commented Feb 4, 2022

No description provided.

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Okay almost fixed.

Error: module issue2051_fail from file /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/issue2051_fail.d conflicts with another module issue2051_fail from file /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//issue2051_fail.d

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Okay this looks like a compiler error now, rather than purely a dub issue.

https://github.com/dlang/dmd/blob/c2b23a3bc73cd8ef7559b86f77f7f9db7ccae507/src/dmd/dmodule.d#L1087

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Interesting part of the -v output from dub:

	Target '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.dub/build/taggedalgebraic-0.11.22/library-unittest-posix.osx.darwin-x86_64-dmd_v2.098.1-AE636001B5339B0D200255F1DA1AEA6B/libtaggedalgebraic.a' doesn't exist, need rebuild.
	taggedalgebraic 0.11.22: building configuration "library"...
	dmd -lib -of/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.dub/build/taggedalgebraic-0.11.22/library-unittest-posix.osx.darwin-x86_64-dmd_v2.098.1-AE636001B5339B0D200255F1DA1AEA6B/libtaggedalgebraic.a -debug -g -w -version=Have_taggedalgebraic -I../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/ ../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/taggedalgebraic/package.d ../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/taggedalgebraic/taggedalgebraic.d ../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/taggedalgebraic/taggedunion.d ../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/taggedalgebraic/visit.d -vcolumns
	Target '/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.dub/build/issue2051-~master/issue2051-test-application-unittest-posix.osx.darwin-x86_64-dmd_v2.098.1-BC18B96D27D3A00892F7B39513F65BD7/issue2051-test-application' doesn't exist, need rebuild.
	issue2051 ~master: building configuration "issue2051-test-application"...
	dmd -c -of/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.dub/build/issue2051-~master/issue2051-test-application-unittest-posix.osx.darwin-x86_64-dmd_v2.098.1-BC18B96D27D3A00892F7B39513F65BD7/issue2051-test-application.o -debug -g -unittest -w -version=Have_issue2051 -version=Have_taggedalgebraic -I../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/ /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//issue2051_success.d /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/dub_test_root_08a3b396_5c8c_41fc_8d00_7b4655d46bcd.d /var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/issue2051_success.d -vcolumns

https://github.com/dlang/dub/runs/5071952412?check_suite_focus=true

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

dmd -c -of/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/.dub/build/issue2051-~master/issue2051-test-application-unittest-posix.osx.darwin-x86_64-dmd_v2.098.1-BC18B96D27D3A00892F7B39513F65BD7/issue2051-test-application.o
-debug -g -unittest -w -version=Have_issue2051 -version=Have_taggedalgebraic -I../../../.dub/packages/taggedalgebraic-0.11.22/taggedalgebraic/source/
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//issue2051_success.d
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/dub_test_root_08a3b396_5c8c_41fc_8d00_7b4655d46bcd.d
/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T/issue2051_success.d

Look at that, it indeed is adding it twice.

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Its happening at some time during Project.addBuildSettings

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

As of https://github.com/dlang/dub/blob/master/source/dub/dub.d#L474 path is wrong. Its double slashes for file as if it was needing escaping. Weird.

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Okay so the problem isn't in loadSingleFilePackage, that means its something very close to the main function associated with commandline.d hum

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

The problem isn't dub...

["./bin/dub", "test", "--single", "/var/folders/24/8k48jl6d249_n_qfxwsl6xvm0000gn/T//issue2051_fail.d"]

@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 4, 2022

Bug in phobos.

https://issues.dlang.org/show_bug.cgi?id=22738

@rikkimax rikkimax changed the title Lets see if that fixes the issue with OSX issue2051 failing. Fix CI issue2051 failing. Feb 5, 2022
@rikkimax
Copy link
Contributor Author

rikkimax commented Feb 5, 2022

This should be good to go now!

@dlang-bot dlang-bot merged commit 12708c7 into dlang:master Feb 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants