Adapt determinePlatform to the new defaults for Win32 #2227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MoonlightSentinel
force-pushed
the
windows-32-default
branch
7 times, most recently
from
0a2f8c2
to
09c48d9
Compare
MoonlightSentinel
force-pushed
the
windows-32-default
branch
3 times, most recently
from
bb51304
to
00b3871
Compare
thewilsonator
approved these changes
Mar 5, 2022
|
Please merge when you're happy with this. |
MoonlightSentinel
force-pushed
the
windows-32-default
branch
2 times, most recently
from
b8015a2
to
74d9ba8
Compare
Starting with DMD 2.099, `-m32` defaults to MsCOFF instead of OMF and `-m32omf` is required to use the OMF format + OPTLINK. This commit changes the logic to select the appropriate logic based on the current compiler version. Potentially using the wrong object file format during platform probing is fine because the codegen is skipped (dmd is invoked with `-c -o-`).
|
Should be good now. But I've got no power here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Starting with DMD 2.099,
-m32defaults to MsCOFF instead of OMF and-m32omfis required to use the OMF format + OPTLINK.This commit changes the logic to select the appropriate logic based
on the current compiler version. Potentially using the wrong object file
format during platform probing is fine because the codegen is skipped
(dmd is invoked with
-c -o-).