Fix issue 9392 - Misleading text about required OS version. #13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update the license * Bump the minimum system requirements for Mac OS X to Snow Leopard (10.6)
|
LGTM. @jordisayol ? |
|
I don't maintain OS X installer. @andralex can merge these pull requests. |
| <pkgref spec="1.12" uuid="4A2C7E44-C304-4FBD-B321-483E2EAD81AB"><config><identifier>org.dlang.dmd.dmd2.pkg</identifier><version>1</version><description></description><post-install type="none"/><requireAuthorization/><installFrom relative="true" mod="true">dmd</installFrom><installTo mod="true">/usr/share/dmd</installTo><flags><followSymbolicLinks/></flags><packageStore type="internal"></packageStore><mod>installTo</mod><mod>installFrom.path</mod><mod>identifier</mod><mod>parent</mod><mod>installTo.path</mod><mod>installFrom.isRelativeType</mod><mod>scripts.postinstall.isRelativeType</mod></config><scripts><postinstall relative="true" mod="true">post-install.sh</postinstall></scripts></pkgref> |
There was a problem hiding this comment.
I'll merge this, but as a question - can this span multiple lines? It's hard to review.
There was a problem hiding this comment.
This particular line above won't be visible anywhere in the user interface. All the text that is visible will automatically wrap to nicely fit the size of the window.
That's also why I removed all newlines, the user interface will automatically handle that much better.
andralex
added a commit
that referenced
this pull request
May 12, 2013
Fix issue 9392 - Misleading text about required OS version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the text in the Mac OS X installer to indicate Snow Leopard or later is required. It also updates the licenses (Phobos now uses Boost and some formatting).