Proposal for std.experimental.allocator #3405
Conversation
| Throws: | ||
| The first two overloads throw only if `alloc`'s primitives do. The | ||
| overloads that involve copy initialization deallocate memory and propagate the | ||
| exception if the copy operation throws. |
There was a problem hiding this comment.
There is a copy-paste error. There are no three overloads for shrinkArray.
P. S. Is there a way on github to search a proper place for comment other than scrolling down the whole pull request?
|
Seems to be blocked by dlang/druntime#1340 |
| version (Posix) private extern(C) int posix_memalign(void**, size_t, size_t); | ||
| version (Windows) | ||
| { | ||
| private extern(C) void* _aligned_malloc(size_t, size_t); |
There was a problem hiding this comment.
these functions (_aligned_malloc and its 2 counterparts) don't exist in the DigitalMars standard C library (snn.lib). So currently DMD 32bit & OptLink are totally unable to link any code that would use these functions and will produce:
Error 42: Symbol Undefined __aligned_free
Error 42: Symbol Undefined __aligned_malloc
Error 42: Symbol Undefined __aligned_realloc
The problem has already hit a few users of DCD when they tried to compile the software with -debug -gc. (because DCD uses a temp. fork of std.experimental.allocators).
Actually there is an underlying bug in DMD or optlink with this because when the external symbols are not used they are eliminated by the compiler (unless the switch -debug -gc are toogled on).
- Build fail on Windows with dmd 2.065.0 dlang-community/DCD#125
- http://forum.dlang.org/post/ueaabkpqlrpzdyemykkz@forum.dlang.org
- http://forum.dlang.org/post/fwnpahollypetjhqkjdw@forum.dlang.org
Maybe the error is that the author thought that either windows.lib or snn.lib contain these functions but they don't.
So under windows
version( DigitalMars ):- solution 1: either the
struct AlignedMallocatorhas to be disabled. - solution 2: the functions have to be manually implemented, based on
malloc(MS states that their implementation is based on malloc, see remark section, so it should be do-able with snn malloc). - solution 3: @WalterBright has to implement the functions in snn.
- solution 1: either the
version( CRuntime_Microsoft ): should be ok (DMD 64 bit).
ghost
mentioned this pull request
| { | ||
| auto result = n.allocate(s); | ||
| if (result.length != s) continue; | ||
| assert(owns(result) == Ternary.yes); |
There was a problem hiding this comment.
If you comment this line out the unit tests will fail.
There was a problem hiding this comment.
Disregard that, it was a unit test for an FreeList!(AllocatorList!(n => Region!Mallocator(blockSize)), ns) that I had in my code somewhere that failed.
There was a problem hiding this comment.
I figured it out. The problem is that the implementation of dispose() is incorrect.
|
Is anything (apart from tester failures) preventing the merge? Concept was approved through review process quite some time ago. |
updated MmapAllocator.deallocate()
…machines at least in 32-bit builds
due to max alloc size
- _aligned_realloc was using an unnecessary temp buffer - _aligned_realloc is now conforms with MSVC specs. in case of realloc failure (keep original block)
|
I rebased and fixed conflicts in posix.mak off of a fresh machine. |
|
Auto-merge toggled on |
Proposal for std.experimental.allocator
|
Hooray! |
|
Awes! |
|
Added to changelog. |
| @@ -2953,6 +2953,7 @@ float ldexp(float n, int exp) @safe pure nothrow @nogc { return ldexp(cast(real) | |||
| } | |||
|
|
|||
| /* workaround Issue 14718, float parsing depends on platform strtold | |||
| typed_allocator.d | |||
Refer to http://forum.dlang.org/thread/vfipmwojmvseqxoiwndr@forum.dlang.org#post-vfipmwojmvseqxoiwndr:40forum.dlang.org for the review.