fix issue 15940 - ImplicitConversionTargets and class alias in struct #4342
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
LGTM |
| { | ||
| class Foo{} | ||
| struct Bar{Foo foo; alias foo this;} | ||
| static assert(ImplicitConversionTargets!(Bar).length == 0); |
There was a problem hiding this comment.
But Bar does convert implicitly to Foo. So ImplicitConversionTargets!Bar should list Foo, shouldn't it? Although it looks like ImplicitConversionTargets doesn't recognize alias this at all.
There was a problem hiding this comment.
it looks like ImplicitConversionTargets doesn't recognize alias this at all.
Yes, it's was just working for a struct containing an alias this to a class (so the bug fixed here), but all the other cases were not. for example:
unittest
{
struct Bar{ubyte d; alias d this;}
static assert(ImplicitConversionTargets!(Bar).length == 0);
}passes. So the fix is conform will the global behavior of the template.
ghost
deleted the
|
Are there any reasons, why this has never been merged? |
ghost
mentioned this pull request
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.