Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to Walter, Andrei Action List #4435

Closed
wants to merge 4 commits into from
Closed

Conversation

burner
Copy link
Member

@burner burner commented Jun 18, 2016

@wilzbach
Copy link
Member

Hmm I do understand that you are quite frustrated at the moment, but could you try to let the text sound a bit more neutral? It's pretty harsh at the moment.
Also quite recently (#4128) I tried to put more information into this file (e. g. on how to make a good contribution to Phobos) and it was argued that the wiki is a better place for contributing guides...

@burner
Copy link
Member Author

burner commented Jun 18, 2016

I know what you mean, but I think sometimes you have to blunt.
If you find a way to transport the same information as clear as the original in a more friendly was, please post it.

@wilzbach
Copy link
Member

@burner as said I believe this should be part of the moderately new Contributing to Phobos guide and I am still in favor of hosting this guide at the CONTRIBUTING.md.

If you find a way to transport the same information as clear as the original in a more friendly was, please post it.

I gave it a try:


New packages in Phobos

Phobos is the standard library of the D programming language and thus tries to standardize APIs to ease development for many other programmers.
Hence it's great if you want to contribute and make Phobos even better, but there are some important points that you should pay attention too.

Blocking points for additions

In general there are some indications why something fits better to dub than to the standard library:

  • Low applicability / potential usage (e.g. QR Code generation, Tribune client)
  • Many valid ways to do something (e.g. UI framework, web server API)
  • Fast moving targets (e.g. CSS library, Game engine)

The bottom line is that if you want to write an amazing library that touches one of those fields, go ahead!
With dub potential users can easily use your library and if it proves to be very popular, it might even find it's way to Phobos ;-)

Finding good points to contribute

If you help Phobos a good starting point to find meaningful tasks is the issue tracker.
Furthermore the D Wishlist contains more abstract, high-level goals.

If you want to write new modules for Phobos, we highly encourage you to stay in touch with the community early on.
Apart from receiving vital feedback and avoiding duplicate efforts, the approval of the community is needed for new additions.
In particular you should stay in contact with Andrei as he can give amazing advises for your design and since he is in charge of managing Phobos he also has absolute veto rights against new additions, which would be quite frustrating after a lot of work.

@burner
Copy link
Member Author

burner commented Jun 19, 2016

If you just could make veto right bold so people will see it I would be real happy with the text.
Thank you for the effort

@wilzbach
Copy link
Member

If you just could make veto right bold so people will see it I would be real happy with the text.
Thank you for the effort

Feel free to directly apply it (and other nitpicks) to your PR ;-)
As Github doesn't allow to copy Markdown intuitively, here is the raw version.

@burner
Copy link
Member Author

burner commented Jun 19, 2016

sorry for the noise I was stupid when posting the request

@burner
Copy link
Member Author

burner commented Jun 19, 2016

@WalterBright please have a look at the update

@dnadlinger
Copy link
Member

Please keep the old headline style – it is visually much more clear when using a text editor to read the file.

The very end of the text reads rather passive-aggressive (and the "as he can give amazing advises for your design" would definitely need rewording), and while I understand your frustration, this is not the place to vent.

What about simply saying something along the lines of:

Apart from receiving vital feedback and avoiding duplicate efforts, the approval of the community is needed for new additions. In particular, be sure to keep in touch with Andrei Alexandrescu, who manages Phobos and can veto new additions.

(Obviously, the wording needs more work.) Even that seems overly ominous to state in the readme, though.

@wilzbach
Copy link
Member

Even that seems overly ominous to state in the readme, though.

As mentioned CONTRIBUTING.md might be a better spot ;-)

@burner
Copy link
Member Author

burner commented Jun 26, 2016

ping @andralex @WalterBright

@burner burner added the @andralex Approval from Andrei is required label Jun 30, 2016

- Low applicability / potential usage (e.g. QR Code generation, Tribune client)
- Many valid ways to do something (e.g. UI framework, web server API)
- Fast moving targets (e.g. CSS library, Game engine)
Copy link
Member

@JackStouffer JackStouffer Jul 14, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add

  • thin D wrappers around popular APIs (e.g. imagemagick, libpng)

@JackStouffer
Copy link
Member

LGTM sans comments

@burner burner closed this Jul 19, 2016
@wilzbach wilzbach deleted the walter_andrei_action_list branch July 12, 2017 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
@andralex Approval from Andrei is required
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants