-
-
Notifications
You must be signed in to change notification settings - Fork 695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 16744: Add Typeof #5662
Conversation
Thanks for your pull request, @MetaLang! We are looking forward to reviewing it, and you should be hearing from a maintainer soon. Some tips to help speed things up:
Bear in mind that large or tricky changes may require multiple rounds of review and revision. Please see CONTRIBUTING.md for more information. Bugzilla references
|
b26f48c
to
53d4911
Compare
This an alternative implementation to #4920
53d4911
to
d39cc3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
I approve this as well |
@UplinkCoder - while this is a nice addition, it still is a new symbol and it this hasn't been approved by @andralex. On the contrary:
-> #5664 reverts this temporarily, s.t. there's enough time to finish the discussion properly. Sorry for the extra work @MetaLang |
I'm not quite sure how it works... should I re-submit the original PR? |
I think so - you might need to be a bit careful on the rebase after the revert has been merged. |
Yah, thanks @wilzbach I do want us to think this over a little better |
This an alternative implementation to #4920