fix Issue 18519: missing curl + phobos = std.net.curl unittest timing out #6824
Conversation
As seen when libcurl cannot be loaded (missing library), the lack of checking causes a new exception to be thrown while another is inflight.
This fixes a thread deadlock that occurs in the test runner if libcurl is missing.
|
Thanks for your pull request, @ibuclaw! Bugzilla references
|
In the context of the issue, this means PASS. However, as people like the auto-tester to be green, I'll partially undo the last commit I guess... |
Moved disabling of tests to the makefile, rather than the module, which prevented tests from running on FreeBSD regardless of what compiler is building. |
… out Disable the std.net.curl tests in the makefile, not the module.
|
Should be good to go. |
|
Doc tester |
|
CC @CyberShadow this doc failure seems to happen more often these days :/ |
Forgot to reply but I think I found & fixed the problem yesterday. |
|
Nice, thanks! |
1 similar comment
|
Nice, thanks! |
Fixes a thread deadlock that occurs in the test runner if libcurl is missing. Library fix for https://gcc.gnu.org/PR88654 Reviewed-on: dlang/phobos#6824 git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@268746 138bc75d-0d04-0410-961f-82ee72b054a4
Second attempt at fixing the issue.
Only a little sceptical that this is more correct here - calling shutdown is recommended however in the docs. In any case, I can no longer reproduce this on Linux after applying patch.