Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Issue 18519: missing curl + phobos = std.net.curl unittest timing out #6824

Merged
merged 3 commits into from
Jan 4, 2019
Merged

fix Issue 18519: missing curl + phobos = std.net.curl unittest timing out #6824

merged 3 commits into from
Jan 4, 2019

Commits on Jan 2, 2019

  1. std.net.curl: Check temporary file exists before removing 

    As seen when libcurl cannot be loaded (missing library), the lack of
checking causes a new exception to be thrown while another is inflight.
    @ibuclaw
    ibuclaw committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    1dcb92a View commit details
    Browse the repository at this point in the history

  2. std.net.curl: Shutdown socket before closing in unittest 

    This fixes a thread deadlock that occurs in the test runner if libcurl
is missing.
    @ibuclaw
    ibuclaw committed Jan 2, 2019
    Configuration menu
    Copy the full SHA
    d36b28c View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2019

  1. fix Issue 18519: missing curl + phobos = std.net.curl unittest timing… 

    … out

Disable the std.net.curl tests in the makefile, not the module.
    @ibuclaw
    ibuclaw committed Jan 3, 2019
    Configuration menu
    Copy the full SHA
    8d51519 View commit details
    Browse the repository at this point in the history