Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

get rid of some GC allocations in sformat and formatElement #7163

Merged
merged 2 commits into from
Sep 1, 2019
Merged

get rid of some GC allocations in sformat and formatElement #7163

merged 2 commits into from
Sep 1, 2019

Conversation

aG0aep6G
Copy link
Contributor

@aG0aep6G
avoid generating a closure in sformat
e13a397
@aG0aep6G
avoid appender in formatElement for strings
018e93c 
On the downside, the new code loops twice over the source
string, meaning it `decode`s every character twice.

On the upside, it writes only one time to memory, avoiding one
or more allocations and a copy from the temporary buffer to the
actual destination.
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @aG0aep6G! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.

If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7163"

@dlang-bot dlang-bot merged commit 05f866c into dlang:master Sep 1, 2019
@aG0aep6G aG0aep6G deleted the sformat-gc branch September 3, 2019 15:00
@aG0aep6G aG0aep6G mentioned this pull request Mar 6, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thewilsonator thewilsonator thewilsonator approved these changes

@andralex andralex Awaiting requested review from andralex andralex is a code owner

Assignees
No one assigned
Labels
auto-merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aG0aep6G @dlang-bot @thewilsonator