Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Issue 20542 - std.math.nextafter(NaN, y) and nextafter(x, NaN) sh… #7380

Merged
merged 2 commits into from
Jan 31, 2020

Conversation

e10s
Copy link
Contributor

@e10s e10s commented Jan 28, 2020

…ould return NaN

@e10s e10s requested a review from ibuclaw as a code owner January 28, 2020 16:20
@dlang-bot
Copy link
Contributor

Thanks for your pull request and interest in making D better, @e10s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
20542 normal std.math.nextafter(NaN, y) and nextafter(x, NaN) should return NaN

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub fetch digger
dub run digger -- build "master + phobos#7380"

//enum real c = 3;
//static assert(is(typeof(nextafter(c, c)) == real));
enum real c = 3;
static assert(is(typeof(nextafter(c, c)) == real));
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When I read #7176 correctly, this unittest was commented out on purpose by @n8sh, as it might not work on every real implementation yet.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It doesn't matter in these special cases as long as realX == realY and isNaN(realVal) work properly at compile time. #7176 just mentions nextUp / nextDown for real, called if both of the arguments are different and not NaN.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't need to comment out those two lines since typeof does not require the contained expression to run in CTFE.

@thewilsonator
Copy link
Contributor

Sorry there has been some network problems, could you please force-push to restart the tests, thanks.

@dlang-bot dlang-bot merged commit 3502f0a into dlang:master Jan 31, 2020
@e10s e10s deleted the issue20542 branch November 11, 2020 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants