-
-
Notifications
You must be signed in to change notification settings - Fork 700
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Issue 20542 - std.math.nextafter(NaN, y) and nextafter(x, NaN) sh… #7380
Conversation
Thanks for your pull request and interest in making D better, @e10s! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub fetch digger
dub run digger -- build "master + phobos#7380" |
//enum real c = 3; | ||
//static assert(is(typeof(nextafter(c, c)) == real)); | ||
enum real c = 3; | ||
static assert(is(typeof(nextafter(c, c)) == real)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't matter in these special cases as long as realX == realY
and isNaN(realVal)
work properly at compile time. #7176 just mentions nextUp
/ nextDown
for real
, called if both of the arguments are different and not NaN.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't need to comment out those two lines since typeof
does not require the contained expression to run in CTFE.
Sorry there has been some network problems, could you please force-push to restart the tests, thanks. |
…ould return NaN