New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/issue 20756 implicitconversiontargets interfaces #7453
Fix/issue 20756 implicitconversiontargets interfaces #7453
Conversation
Thanks for your pull request and interest in making D better, @FeepingCreature! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#7453" |
221109b
to
b6d92ed
Compare
I'm a bit worried that the docs explicitly call out "a class derived from |
If you're changing the docs, you should clarify if it works with |
I cannot think of any reason why it wouldn't, but I don't know anything about C++ classes/interfaces and their D binding. Who could I ping about that? |
Sorry I missed this. Probably @jacob-carlborg and/or @Geod24 |
I guess the above example should work for for C++ and Objective-C interfaces. But keep in mind they don't inherit from Object. There are also COM interfaces, which I don't know how they behave. Ideally there should be tests for all kinds. Although Objective-C interfaces are deprecated. |
ping @FeepingCreature . What is the status of this? |
85fe3c4
to
a286d99
Compare
Rebased, but note that I don't remember what I needed this for. |
Actually, can't this definitely be closed? Looking at the changelog, we have edit: Ah shit, it doesn't. I'll make a separate PR before that's released, so we don't make a new template with the exact same issue... |
Repro:
Expected:
AliasSeq!(A)
Got:
AliasSeq!()