-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DSSv3] Fix Issue 16218 - Windows std.file.readImpl should be marked @system #8184
Conversation
Thanks for your pull request and interest in making D better, @vladchicos! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8184" |
I think that rebasing might fix the current tester failures. |
I'm kind of surprised that this function is not called from @safe code in phobos. |
std/file.d
Outdated
@@ -402,24 +402,24 @@ version (Posix) private void[] readImpl(scope const(char)[] name, scope const(FS | |||
|
|||
|
|||
version (Windows) private void[] readImpl(scope const(char)[] name, scope const(FSChar)* namez, | |||
size_t upTo = size_t.max) @safe | |||
size_t upTo = size_t.max) @system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RazvanN7, I changed it. Now it seems to pass the tests.
I marked readImpl with @System because most of its code was already @trusted.