Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 22369 - Omit unreachable statements in std.concurrency #8266

Merged
merged 1 commit into from
Oct 13, 2021

Conversation

MoonlightSentinel
Copy link
Contributor

Instantiating these templates with noreturn values / callbacks causes
the versioned statements to become unreachable.


Includes #8265 to make the test case compilable

@dlang-bot
Copy link
Contributor

dlang-bot commented Oct 8, 2021

Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please verify that your PR follows this checklist:

  • My PR is fully covered with tests (you can see the coverage diff by visiting the details link of the codecov check)
  • My PR is as minimal as possible (smaller, focused PRs are easier to review than big ones)
  • I have provided a detailed rationale explaining my changes
  • New or modified functions have Ddoc comments (with Params: and Returns:)

Please see CONTRIBUTING.md for more information.


If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment.

Bugzilla references

Auto-close Bugzilla Severity Description
22369 normal Unreachable statements in std.concurrency with noreturn values / callbacks

Testing this PR locally

If you don't have a local development environment setup, you can use Digger to test this PR:

dub run digger -- build "master + phobos#8266"

@MoonlightSentinel MoonlightSentinel force-pushed the noreturn/concurrency branch 2 times, most recently from d99b6e4 to 5c48b5e Compare October 8, 2021 20:23
@thewilsonator
Copy link
Contributor

It seems to me that noreturn has the same stink as void in requiring these special cases

@MoonlightSentinel
Copy link
Contributor Author

Not particulary happy about these static-if's. But i don't think noreturn is to blame for better diagnostics, it's just the general problem of the overzealous statement not reachable warning in generic code.

@RazvanN7
Copy link
Collaborator

This seems to have exposed an ICE.

Instantiating these templates with noreturn values / callbacks causes
the versioned statements to become unreachable.
@MoonlightSentinel
Copy link
Contributor Author

This seems to have exposed an ICE.

One of them, but the blocker for this PR was fixed in dlang/dmd#13142.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants