-
-
Notifications
You must be signed in to change notification settings - Fork 701
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix 22369 - Omit unreachable statements in std.concurrency #8266
Conversation
Thanks for your pull request and interest in making D better, @MoonlightSentinel! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8266" |
d99b6e4
to
5c48b5e
Compare
It seems to me that |
Not particulary happy about these static-if's. But i don't think noreturn is to blame for better diagnostics, it's just the general problem of the overzealous |
This seems to have exposed an ICE. |
5c48b5e
to
a435219
Compare
Instantiating these templates with noreturn values / callbacks causes the versioned statements to become unreachable.
a435219
to
4cf70e6
Compare
One of them, but the blocker for this PR was fixed in dlang/dmd#13142. |
Instantiating these templates with noreturn values / callbacks causes
the versioned statements to become unreachable.
Includes #8265 to make the test case compilable