-
-
Notifications
You must be signed in to change notification settings - Fork 694
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue 22383 is solved so now can use noreturn #8283
Conversation
Thanks for your pull request and interest in making D better, @dukc! We are looking forward to reviewing it, and you should be hearing from a maintainer soon.
Please see CONTRIBUTING.md for more information. If you have addressed all reviews or aren't sure how to proceed, don't hesitate to ping us with a simple comment. Bugzilla references
Testing this PR locallyIf you don't have a local development environment setup, you can use Digger to test this PR: dub run digger -- build "master + phobos#8283" |
Cause for ICE: https://issues.dlang.org/show_bug.cgi?id=22390 |
What's the motivation for this? Does this enable any specific usage that the previous version didn't? If so, the PR should include a unit test for that usage. |
Some (possible) minor advantages(?):
|
Isn't the entire point of using Voldemort types to prevent users from relying on the concrete types of ranges? The only guarantee Regardless, if this is intended to be a supported use-case, there should be a unit test for it. |
True, relying on that behavior would be problematic when |
But there is one useful property with |
I'd say it's fine to use a |
@dukc I am going to close this as the implementation of noreturn is still half baked. We can come back to this later. |
Okay |
Seems strange to close this outright. Why not label as "blocked" if it's only being held back by compiler issues? |
@pbackus I did not see the point in having this PR in the queue while |
Issue 22390 has been fixed. Let's give this another spin. |
Tried to get this to compile. You guessed it: 1-3 more ICEs dug up from this rabbit hole. Here: https://issues.dlang.org/show_bug.cgi?id=23331 |
I close this for now. This PR has resulted in three different bug reports already, two of them ICEs. When this PR compiles and passes the tests after enought ICEs are solved, it's still likely that some client code that happens to use empty |
However, this is still draft because the compiler ICEd when testing