Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve testing #239

Merged
merged 3 commits into from
Jul 3, 2017
Merged

Improve testing #239

merged 3 commits into from
Jul 3, 2017

Conversation

wilzbach
Copy link
Member

@wilzbach wilzbach commented Jul 3, 2017

Follow-up to #238

Maybe build tools with -de?

Good idea - especially with daily crons form Travis we should get notified when stuff breaks.

Supersedes #233

@dlang-bot
Copy link
Contributor

Thanks for your pull request, @wilzbach!

Bugzilla references

Your PR doesn't reference any Bugzilla issue.

If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog.

@wilzbach wilzbach mentioned this pull request Jul 3, 2017
@wilzbach wilzbach force-pushed the improve-testing branch 3 times, most recently from cf4f4d4 to 1dd8e97 Compare July 3, 2017 01:40
@JackStouffer
Copy link
Member

Looks like it's unable to find curl?

@wilzbach
Copy link
Member Author

wilzbach commented Jul 3, 2017

Looks like it's unable to find curl?

Yep, the weird thing is that we have a similar Travis config as at DMD:

addons:
  apt:
    packages:
    - g++-multilib
    - libcurl3-gnutls:i386

I tried a few things and changing the posix.mak target was my last attempt.
Ideas? Maybe libcurl4-openssl-dev?

@CyberShadow
Copy link
Member

On an Ubuntu Server 16.04 box:

vladimir@k3:~$ dpkg-query -S libcurl.so
libcurl3:i386: /usr/lib/i386-linux-gnu/libcurl.so.4.4.0
libcurl3:amd64: /usr/lib/x86_64-linux-gnu/libcurl.so.4.4.0
libcurl4-openssl-dev:amd64: /usr/lib/x86_64-linux-gnu/libcurl.so
libcurl3:i386: /usr/lib/i386-linux-gnu/libcurl.so.4
libcurl3:i386: /usr/lib/i386-linux-gnu/libcurl.so.3
libcurl3:amd64: /usr/lib/x86_64-linux-gnu/libcurl.so.4
libcurl3:amd64: /usr/lib/x86_64-linux-gnu/libcurl.so.3

Seems like you need libcurl4-openssl-dev for libcurl.so proper. Try libcurl4-openssl-dev:i386?

@wilzbach wilzbach force-pushed the improve-testing branch 7 times, most recently from fe19bdc to 90ecf25 Compare July 3, 2017 17:30
@wilzbach
Copy link
Member Author

wilzbach commented Jul 3, 2017

I think I finally got it to work 🎉

image

Apparently we can't include libcurl4-openssl-dev:i386 by default - sorry for the rebase noise.

@dlang-bot dlang-bot merged commit 14db827 into dlang:master Jul 3, 2017
@@ -61,14 +61,7 @@ dustmite: $(ROOT)/dustmite
$(ROOT)/dustmite: DustMite/dustmite.d DustMite/splitter.d
$(DMD) $(DFLAGS) DustMite/dustmite.d DustMite/splitter.d -of$(@)

#dreadful custom step because of libcurl dmd linking problem (Bugzilla 7044)
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's quite interesting that this isn't needed anymore, but pragma(lib, "curl") does the trick now.

@wilzbach wilzbach deleted the improve-testing branch July 3, 2017 17:44
@CyberShadow
Copy link
Member

@wilzbach rdmd_test fails for me locally because stdiobase is gone but it's imported by rdmd's, --eval, any idea why it's passing on Travis?

@wilzbach
Copy link
Member Author

wilzbach commented Jul 4, 2017

any idea why it's passing on Travis?

Best guess: we aren't passing the DMD built with digger to the testsuite - will have a look later.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants