-
-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve testing #239
Improve testing #239
Conversation
Thanks for your pull request, @wilzbach! Bugzilla referencesYour PR doesn't reference any Bugzilla issue. If your PR contains non-trivial changes, please reference a Bugzilla issue or create a manual changelog. |
cf4f4d4
to
1dd8e97
Compare
Looks like it's unable to find curl? |
Yep, the weird thing is that we have a similar Travis config as at DMD:
I tried a few things and changing the posix.mak target was my last attempt. |
On an Ubuntu Server 16.04 box:
Seems like you need |
fe19bdc
to
90ecf25
Compare
@@ -61,14 +61,7 @@ dustmite: $(ROOT)/dustmite | |||
$(ROOT)/dustmite: DustMite/dustmite.d DustMite/splitter.d | |||
$(DMD) $(DFLAGS) DustMite/dustmite.d DustMite/splitter.d -of$(@) | |||
|
|||
#dreadful custom step because of libcurl dmd linking problem (Bugzilla 7044) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's quite interesting that this isn't needed anymore, but pragma(lib, "curl")
does the trick now.
@wilzbach rdmd_test fails for me locally because stdiobase is gone but it's imported by rdmd's, |
Best guess: we aren't passing the DMD built with digger to the testsuite - will have a look later. |
Follow-up to #238
Good idea - especially with daily crons form Travis we should get notified when stuff breaks.
Supersedes #233