update to work with certbot 2.8.0 (requires different command-line args) #95
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
ping. no interest in merging this? |
visibilityspots
added a commit
to visibilityspots/dockerfile-certbot-s3front
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
the plugin no longer works with certbot when I installed it recently (2.8.0). I wasn't intimate with the plugin architecture
before now, but looking at the current code and documentation the plugin name is whatever the name specified in the
package entry_points definition. Those names were "auth" and "installer". The name "auth" cannot work at all against current certbot because it breaks inside their (buggish) argument pre-parser which picks out "auth" as a verb instead of an argument to '-a'. Beyond that though since there's no longer a package-name qualifier attached "auth" and "installer" seem a bit too generic, so I prepended these with "s3front_". This does mean that the command-line args are broken for previous but I didn't think forcing the "package_name:" on the front of them was a great option either since it kind of infers/pretends that the plugin mechanism works the same as it did.
Aside from plugin naming the certbot internals also now filter plugins according to interfaces they implement so I needed to add that otherwise they get filtered out. Aside from that everything seems to still work great! Thanks for creating this very useful bit of software!