Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double quote in password should be escaped #29

Closed
dlarrick opened this issue Jun 18, 2022 · 2 comments
Closed

Double quote in password should be escaped #29

dlarrick opened this issue Jun 18, 2022 · 2 comments

Comments

@dlarrick
Copy link
Owner

See dlarrick/hass-kumo#75 (comment)

This user had a password with a double-quote in it, which will result in early termination of the JSON string in the POST body.

https://github.com/dlarrick/pykumo/blob/master/pykumo/py_kumo_cloud_account.py#L76-L77 should be enhanced to replace a " in the password (and, I guess, username as well, but who does that) with \" prior to assembling the POST body.

@ehagan
Copy link
Contributor

ehagan commented Jun 18, 2022

I changed my kumo cloud password back to one with a double quote in it and was able to fetch my units with this change.

@dlarrick
Copy link
Owner Author

I'll bump the version of pykumo in hass-kumo when it goes out of beta in a few days

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants