Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add humidity from MHK2 sensors if available. #20

Merged
merged 2 commits into from
Jan 6, 2022

Conversation

dmcc
Copy link
Contributor

@dmcc dmcc commented Dec 17, 2021

Work towards issue #19

@dlarrick dlarrick changed the base branch from master to mhk-humidity January 6, 2022 15:15
@dlarrick
Copy link
Owner

dlarrick commented Jan 6, 2022

Merging this into a local branch for review

@dlarrick dlarrick merged commit 2c19158 into dlarrick:mhk-humidity Jan 6, 2022
@dlarrick
Copy link
Owner

dlarrick commented Jan 7, 2022

@dmcc do you have a complete response from the {"c":{"mhk2":{"status":{}}}} query that you're willing to share? Stripped of any sensitive information of course.

@dmcc
Copy link
Contributor Author

dmcc commented Jan 7, 2022

Thanks for taking a look! #19 (comment) is roughly that (slightly different request). I should be able to capture a request for {"c":{"mhk2":{"status":{}}}} this weekend.

Incidentally, I'm confused why the mhk2 entry doesn't include any temperature information since it presumably has that sensor as well, but I guess one thing at a time (LMK if you have ideas on where it may live).

@dlarrick
Copy link
Owner

dlarrick commented Jan 7, 2022

Aha! Your comment on #19 is plenty, thanks. If mkh2 unit has a temperature sensor in it maybe it shows up as a normal sensor? Though they could have done that with humidity as well. Who knows...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants