Add further tests for disabled old delivery channel properties

dlcs · May 31, 2024 · f81432b · f81432b
1 parent c187c58
commit f81432b
Showing 1 changed file with 98 additions and 1 deletion.
diff --git a/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs b/src/protagonist/API.Tests/Converters/LegacyModeConverterTests.cs
@@ -111,7 +111,7 @@ public void VerifyAndConvertToModernFormat_ModelIdSet_WhenNoModelId()
     }
 
     [Fact]
-    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelEmulationDisabled()
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForImage()
     {
         // Arrange
         var hydraImage = new Image()
@@ -127,6 +127,103 @@ public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliver
         convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
     }
 
+    [Theory]
+    [InlineData("fast-higher")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/fast-higher")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForImage(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Image,
+            Origin = "something.jpg",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+
+    [Fact]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForVideo()
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp4",
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+
+    [Theory]
+    [InlineData("video-max")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/video-max")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForVideo(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp4",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+
+    [Fact]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_ForAudio()
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp3",
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+
+    [Theory]
+    [InlineData("audio-max")]
+    [InlineData("https://api.dlc.services/imageOptimisationPolicies/audio-max")]
+    public void VerifyAndConvertToModernFormat_AddsNoDeliveryChannels_WhenOldDeliveryChannelPropertiesDisabled_AndImageOptimisationPolicyValid_ForAudio(
+        string imageOptimisationPolicy)
+    {
+        // Arrange
+        var hydraImage = new Image()
+        {
+            Family = AssetFamily.Timebased,
+            Origin = "something.mp3",
+            ImageOptimisationPolicy = imageOptimisationPolicy
+        };
+
+        // Act
+        var convertedImage = LegacyModeConverter.VerifyAndConvertToModernFormat(hydraImage, false);
+
+        // Assert
+        convertedImage.DeliveryChannels.Should().BeNullOrEmpty();
+    }
+
     [Fact]
     public void VerifyAndConvertToModernFormat_AddsDeliveryChannels_WhenNotSet_ForImage()
     {