-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure s.json thumb sizes are emitted in sizes
from named query manifests and single-asset manifests
#631
Comments
|
|
protagonist/src/protagonist/Orchestrator/Infrastructure/IIIF/IIIFCanvasFactory.cs Line 186 in 52a9f75
We will need to take performance implications into account, particularly for larger NQs |
Also need to make sure that "secret" thumbnails are also present in the sizes list. |
This ticket will also need to cover handling skipped tests in |
...so that clients can see what sized thumbs were created in bulk, for a named query, as well as individually.
Clients including the DDS.
At the moment protagonist deduces these sizes, so is potentially prone to rounding errors.
It won't be doing any deducing in future, just reading the sizes that cantaloupe made.
Requirement outlined above resulted in RFC being written (#767)
Update after RFC
RFC documents how metadata that can be read in bulk will be stored in
AssetApplicationMetadata
.This ticket is blocked by #787 - once that is done we will have the
AssetApplicationMetadata
table available. This ticket is then to update classes involved in NQ + single-asset manifest generation (likelyIIIFManifestBuilder
and/orIIIFCanvasFactory
) to read the thumbnail sizes generated, rather than deducing them.However, when first introduced, and possibly for some time after, this new table won't be populated with
"ThumbSizes"
metadata value for every asset. So until that happens we need a method of attempting to read the actual values but falling back to calculating if there is no"ThumbSizes"
metadata.Initially upon release all new-format (ie using IIIF Size Param) thumb sizes will be based on confined sizes (
!w,h
) so we will be able to calculate them using existing methods inAssetX
(updating method to only calculate confined thumb sizes).Implementation points:
.Include()
in the base NQ IQueryable generator - need a hook to include relevant data only depending on projection.ImageDeliveryChannel
with PolicyId - this can be used to load + cache PolicyData if required (use same local caching mechanism as is currently happening with ThumbsPolicy)."sizes
the sizes read here need to populate the"thumbnail"
property on manifestAcceptance Criteria
The text was updated successfully, but these errors were encountered: