Get image and thumbnail channels to work in engine #777
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
force-pushed
the
feature/imageThumbsHandling
branch
from
c4faa62
to
e669dfd
Compare
JackLewis-digirati
force-pushed
the
feature/imageThumbsHandling
branch
from
f582f99
to
48228a0
Compare
donaldgray
reviewed
Apr 4, 2024
src/protagonist/Engine/Ingest/Image/ImageServer/Clients/CantaloupeThumbsClient.cs
Outdated
Show resolved
Hide resolved
src/protagonist/Engine/Ingest/Image/ImageServer/Clients/CantaloupeThumbsClient.cs
Outdated
Show resolved
Hide resolved
src/protagonist/Engine/Ingest/Image/ImageServer/Clients/CantaloupeThumbsClient.cs
Show resolved
Hide resolved
This was referenced Apr 5, 2024
donaldgray
approved these changes
Apr 8, 2024
JackLewis-digirati
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #629
Links WDC-37
This PR adds the ability for the image and thumbs delivery channel to be correctly processed by engine and viewed using orchestrator. It also splits the image processor for thumbs out of appetiser to use special server to generate thumbnails
This PR additionally bumps ImageSharp to 3.1.3, which resolves #754