Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Serialised ImageService2 should have no type #868

Closed
donaldgray opened this issue Jun 25, 2024 · 1 comment · Fixed by #873
Closed

Serialised ImageService2 should have no type #868

donaldgray opened this issue Jun 25, 2024 · 1 comment · Fixed by #873
Assignees
Labels
bug Something isn't working orchestrator

Comments

@donaldgray
Copy link
Member

donaldgray commented Jun 25, 2024

Single item and named-query manifests that serialise ImageService2 resources always include the @type value of "ImageService2", e.g.

"service": {
  "@context": "http://iiif.io/api/image/2/context.json",
  "@id": "https://dlc.services/thumbs/1/2/foo",
  "@type": "ImageService2",
  "profile": "http://iiif.io/api/image/2/level0.json",
  "sizes": [

However, this value is incorrect as per documentation:

`@type | Optional | The type for the Image. If present, the value must be the string iiif:Image.

Given the above we can either omit it or make it "iiif:Image" as "ImageService2" wasn't introduced until v3 but only when rendering on a Presentation2 manifest.

This may require an update to the https://github.com/digirati-co-uk/iiif-net nuget package and/or an update to DLCS.

@donaldgray
Copy link
Member Author

@griffri - I'd missed this on above requirement but "type" on IIIF Image2 info.json files shouldn't be ImageService2 either. However, rather than omit we should set this to iiif:Image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working orchestrator
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants