Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Omit type from serialized ImageService2 in Presentation2 manifests #873

Merged
merged 7 commits into from
Jun 27, 2024
Merged

Omit type from serialized ImageService2 in Presentation2 manifests #873

merged 7 commits into from
Jun 27, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Jun 27, 2024 •
edited
Loading

Resolves #868 and DLCS-855

This PR omits the @Type field from ImageService2 when rendering Presentation2 manifests.

Package upgrades:

  • iiif-net 0.2.3 -> 0.2.5
  • AngleSharp 0.16.1 -> 0.17.3

@griffri griffri marked this pull request as ready for review June 27, 2024 12:19
@griffri griffri requested a review from a team as a code owner June 27, 2024 12:19
@griffri griffri requested a review from tomcrane June 27, 2024 12:19
donaldgray
donaldgray approved these changes Jun 27, 2024
View reviewed changes
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@donaldgray donaldgray self-requested a review June 27, 2024 12:57
@donaldgray donaldgray merged commit 3c738a4 into main Jun 27, 2024
9 checks passed
@donaldgray donaldgray deleted the fix/omit_type_p2manifest branch June 27, 2024 16:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@JackLewis-digirati JackLewis-digirati JackLewis-digirati approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane is a code owner automatically assigned from dlcs/dlcs-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Serialised ImageService2 should have no type
3 participants
@griffri @donaldgray @JackLewis-digirati