Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Hydra model for delivery channels #734

Merged
merged 4 commits into from
Feb 14, 2024
Merged

Add Hydra model for delivery channels #734

merged 4 commits into from
Feb 14, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Feb 12, 2024 •
edited
Loading

Resolves #717

This PR adds a new DeliveryChannel Hydra class and replaces the string[] DeliveryChannels property in HydraModel.Image with DeliveryChannel[] DeliveryChannels. It also removes the OldDeliveryChannels property.

@griffri griffri marked this pull request as ready for review February 12, 2024 17:37
@griffri griffri requested a review from a team as a code owner February 12, 2024 17:37
@tomcrane
Copy link
Contributor

From discussion

DeliveryChannel shoudl not have customerId, SpaceId or ModelId; it's only ever used inline in PUTS GETS and POSTs

@tomcrane tomcrane mentioned this pull request Feb 13, 2024
Closed
@griffri griffri merged commit 80d334e into develop Feb 14, 2024
1 check passed
@donaldgray donaldgray deleted the hydra_new_deliverychannels branch February 15, 2024 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@JackLewis-digirati JackLewis-digirati JackLewis-digirati approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane is a code owner automatically assigned from dlcs/dlcs-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace string[] DeliveryChannels with DeliveryChannel[] DeliveryChannels
4 participants
@griffri @tomcrane @donaldgray @JackLewis-digirati