Add API endpoints for default delivery channels for a customer #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JackLewis-digirati
changed the title
JackLewis-digirati
force-pushed
the
feature/defaultDeliveryChannelApi
branch
from
a841fd2
to
01b9db7
Compare
donaldgray
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Looking at this branch in IDE it might be useful to add new namespaces under API.Features.DeliveryChannels.Requests. As-is there's a big list and almost duplicate requests for DeliveryChannelPolicy and DefaultDeliveryChannel
e.g. as-is
API/
Features/
DeliveryChannels/
Requests/
CreateCustomerDefaultDeliveryChannel.cs
CreateDeliveryChannelPolicy.cs
DeleteCustomerDefaultDeliveryChannel.cs
DeleteDeliveryChannelPolicy.cs
GetCustomerDefaultDeliveryChannel.cs
...
could be
API/
Features/
DeliveryChannels/
Requests/
Defaults/
CreateCustomerDefaultDeliveryChannel.cs
DeleteCustomerDefaultDeliveryChannel.cs
GetCustomerDefaultDeliveryChannel.cs
Policies/
CreateDeliveryChannelPolicy.cs
DeleteDeliveryChannelPolicy.cs
...
Also general question on naming - do we need "Customer" in controller name, and all of the requests? Would CreateDefaultDeliveryChannel etc suffice?
src/protagonist/API/Features/DeliveryChannels/CustomerDefaultDeliveryChannelsController.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/CustomerDefaultDeliveryChannelsController.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/CreateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/CreateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/CreateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/UpdateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/UpdateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/UpdateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/CreateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/Requests/UpdateCustomerDefaultDeliveryChannel.cs
Outdated
Show resolved
Hide resolved
JackLewis-digirati
force-pushed
the
feature/defaultDeliveryChannelApi
branch
3 times, most recently
from
5992e3d
to
3e99ac2
Compare
JackLewis-digirati
force-pushed
the
feature/defaultDeliveryChannelApi
branch
from
3e99ac2
to
c77e764
Compare
griffri
reviewed
Mar 11, 2024
.../API.Tests/Features/DeliveryChannels/Validation/HydraDefaultDeliveryChannelValidatorTests.cs
Outdated
Show resolved
Hide resolved
src/protagonist/API/Features/DeliveryChannels/CustomerDefaultDeliveryChannelsController.cs
Outdated
Show resolved
Hide resolved
...protagonist/API/Features/DeliveryChannels/Validation/HydraDefaultDeliveryChannelValidator.cs
Show resolved
Hide resolved
donaldgray
approved these changes
Mar 11, 2024
src/protagonist/DLCS.Repository.Tests/DLCS.Repository.Tests.csproj
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #720
This pull requests adds API endpoints to
GET,GET by Id,PUT,POSTandDELETEdefault delivery channels