Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add AV settings to Engine #748

Merged
merged 3 commits into from
Mar 12, 2024
Merged

Add AV settings to Engine #748

merged 3 commits into from
Mar 12, 2024

Conversation

JackLewis-digirati
Copy link
Contributor

@JackLewis-digirati JackLewis-digirati commented Feb 28, 2024 •
edited
Loading

This PR is related to #726

It provides an additional endpoint used to provide valid iiif-av policies for use by the API

This is tracked by a sub-task here

@JackLewis-digirati JackLewis-digirati marked this pull request as ready for review March 7, 2024 15:04
@JackLewis-digirati JackLewis-digirati requested a review from a team as a code owner March 7, 2024 15:04
griffri
griffri approved these changes Mar 11, 2024
View reviewed changes
Copy link
Contributor

@griffri griffri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine, there's just one (admittedly nitpicky!) thing that's on my mind.

src/protagonist/Engine/Ingest/IngestController.cs Outdated Show resolved Hide resolved
@JackLewis-digirati JackLewis-digirati merged commit 3cabfce into develop Mar 12, 2024
9 checks passed
@JackLewis-digirati JackLewis-digirati deleted the feature/engineAvSettings branch March 12, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@griffri griffri griffri approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane is a code owner automatically assigned from dlcs/dlcs-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@JackLewis-digirati @donaldgray @griffri