Await unawaited task when setting None policy #791
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The .Id property on returned task was accessed, which is a valid property of a Task hence IDE not flagging. Resulted in seemingly random id property being set for 'none'
JackLewis-digirati
approved these changes
Apr 8, 2024
griffri
approved these changes
Apr 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug introduced in #778. When switching
IDeliveryChannelPolicyRepositoryto beasyncI missed anawait. This is normally flagged in IDE but the the.Idproperty on returned task was accessed, which is a valid property of a Task and of same type hence IDE not flagging. Resulted in seemingly random id property being set for 'none'