Create default thumbs on all image assets #793
Conversation
|
did have a question on this, which was whether to add the setting to |
| } | ||
|
|
||
| // temporary - will be replaced by call to application metadata table | ||
| var thumbs = await thumbRepository.GetAllSizes(i.Id); |
There was a problem hiding this comment.
I think this changes behaviour, previously it was only returning open thumbs.
Not worth changing now - as comment says this is temporary. However, we'll need to bear in mind we want open thumbs only, not all. GetThumbnailSizesForImage is what was called in all instances and that calls AssetX.GetAvailableThumbSizes() which will return available sizes only
There was a problem hiding this comment.
Given I was making changes in the area, I did just change this to GetOpenSizes - though might need to look into some safeguarding with this change if all thumbs are auth
src/protagonist/Orchestrator/Infrastructure/IIIF/IIIFCanvasFactory.cs
Outdated
Show resolved
Hide resolved
Resolves #627
Links wdc-39
This PR adds "unofficial thumbs" to every iiif-image request, so that even if the the
thumbschannel is not specified, there will still be thumbnails generated for use by the DLCS.The thumbnails that will be ultimately generated for an image, is a union of the unofficial thumbs, with the delivery channel policy of the thumbs channel, so that duplicate thumbnails are not created
However, these specific thumbnails will not be advertised to the customer, but will show up on a info.json request under the
sizesproperty.