Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat region parameters that cover the entire image as 'full' in Orchestrator #800

Merged
merged 7 commits into from
Apr 15, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Apr 11, 2024

Resolves #781

This PR updates ImageRequestHandler to treat IIIF image requests that request a region covering the entire image (e.g 0,0,512,512 for a 512x512 image) as full. It also includes tests that verify this behaviour.

@griffri griffri force-pushed the feature/iiif_detect_full_image branch from 25e923f to c4d6e3d Compare April 11, 2024 12:37
@griffri griffri marked this pull request as ready for review April 11, 2024 15:45
@griffri griffri requested a review from a team as a code owner April 11, 2024 15:45
Copy link
Member

@donaldgray donaldgray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@griffri griffri merged commit 75edefc into develop Apr 15, 2024
9 checks passed
@griffri griffri deleted the feature/iiif_detect_full_image branch April 15, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Detect IIIF region parameter that represents full image
3 participants