Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix API returning 500 after a successful reingest #812

Merged
merged 2 commits into from
Apr 17, 2024
Merged

Fix API returning 500 after a successful reingest #812

merged 2 commits into from
Apr 17, 2024

Conversation

griffri
Copy link
Contributor

@griffri griffri commented Apr 17, 2024 •
edited
Loading

Resolves #811 and WDC-79

This PR fixes an issue with the API where a serialization issue would cause the /reingest endpoint to return 500, even if the request to the engine was successful.

@griffri griffri marked this pull request as ready for review April 17, 2024 14:02
@griffri griffri requested a review from a team as a code owner April 17, 2024 14:02
@griffri griffri merged commit a5b5153 into develop Apr 17, 2024
9 checks passed
@griffri griffri deleted the fix/reingest_returns_500 branch April 17, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donaldgray donaldgray donaldgray approved these changes

@tomcrane tomcrane Awaiting requested review from tomcrane tomcrane is a code owner automatically assigned from dlcs/dlcs-developers

@JackLewis-digirati JackLewis-digirati Awaiting requested review from JackLewis-digirati JackLewis-digirati is a code owner automatically assigned from dlcs/dlcs-developers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/reingest endpoint returning 500 error
2 participants
@griffri @donaldgray