Remove unused navigation properties #850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Primarily removed to avoid serialisation issue but they are reduntant.
tomcrane
approved these changes
May 15, 2024
JackLewis-digirati
approved these changes
May 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Primarily removed to avoid serialisation issue but they are reduntant. We likely want a more robust converter than this but it solves the immediate issue.
It's unlikely that we'd want to load a
DeliveryChannelPolicyand from there see allImageDeliveryChannelsassociated with it (could lead to a huge object graph). Similarly it's unlikely that we'd want to start withImageDeliveryChanneland get associatedAsset- all queries would start withAsset.Verified that no migrations is required after making change to context.